jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform
https://www.jaegertracing.io/
Apache License 2.0
20.15k stars 2.4k forks source link

[Bug]: ci-kafka test workflow started frequently failing #4420

Open yurishkuro opened 1 year ago

yurishkuro commented 1 year ago

What happened?

ci-kafka test workflow started frequently failing

Steps to reproduce

.github/workflows/ci-kafka.yml

Expected behavior

tests should succeed

Relevant log output

integration.go:203: trace not found
    integration.go:203: trace not found
    integration.go:207: 
            Error Trace:    /home/runner/work/jaeger/jaeger/plugin/storage/integration/integration.go:207
            Error:          Should be true
            Test:           TestKafkaStorage/GetTrace
    trace_compare.go:57: 
            Error Trace:    /home/runner/work/jaeger/jaeger/plugin/storage/integration/trace_compare.go:57
                                        /home/runner/work/jaeger/jaeger/plugin/storage/integration/integration.go:208
            Error:          Expected value not to be nil.
            Test:           TestKafkaStorage/GetTrace
--- FAIL: TestKafkaStorage (10.64s)
    --- FAIL: TestKafkaStorage/GetTrace (10.05s)
FAIL
FAIL    github.com/jaegertracing/jaeger/plugin/storage/integration  10.661s


### Screenshot

_No response_

### Additional context

It could be timing issue, like not waiting long enough for Kafka broker to start properly before running the test. Just a guess though, need to look through the logs to confirm that's the case.

### Jaeger backend version

_No response_

### SDK

_No response_

### Pipeline

_No response_

### Stogage backend

_No response_

### Operating system

_No response_

### Deployment model

_No response_

### Deployment configs

_No response_
yurishkuro commented 1 year ago

The issue seems to be the the recent versions of bitnami/kafka. I pinned it to 3.1.0 in #4421 and the tests started passing again.