Closed yurishkuro closed 10 months ago
Hey Yuri, I just came over this. how do you think we can adjust Process to have otel.library.name
and enable some resource discovery module? Is there any other tags adjusted the same way? How do you see the changes when take this into account? Thanks
adjust Process to have otel.library.name
The simplest way would be to add a new adjuster (under model/adjuster
) to Jaeger that would move certain attributes from span.tags to span.process.tags.
enable some resource discovery module
That I don't know, it needs looking into OTEL SDK code.
Hey @yurishkuro, I'm looking to making my first contribution to jaeger...This issue seems like a good one, Can I be assigned this? I see it's been a while since this issue was last picked up.
Feel free to pick it up. We do not explicitly assign issues.
Sorry... I've encountered the same issue with the previous PR contributor. I've tackled the resource discovery and tag adjuster. Should I remove my tag adjuster and only apply the resource discovery to respect the previous PR contributor?
Hey, I was having trouble even getting this off the ground...I think you should go ahead and merge your prs. I'll look into some easier issues to get started with
When query-service span is generated by Jaeger client, we get some Process information filled out:
However, when the spans are produced by OTEL SDK, Process is empty.
We need to find out
otel.library.name
, should not be in the span Tags, but in the process. Ideally this should be fixed upstream in OTEL, but we could also implement it internally as amodel/adjuster
.