jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform
https://www.jaegertracing.io/
Apache License 2.0
20.51k stars 2.44k forks source link

[Bug]: Consumer metrics should have a tag with topic name #4777

Closed abliqo closed 1 year ago

abliqo commented 1 year ago

What happened?

The recent change 4593 updated the consumer code of the ingester to support ingestion from multiple Kafka topics when sarama consumer is created in custom way with multiple topics. However, the metrics lack the tag with topic name.

Steps to reproduce

  1. Ingest from multiple Kafka topics with sarama consumer created in custom way.
  2. Check the metric with name name:sarama-consumer.messages - it does not have information about the topic.

Expected behavior

All consumer metrics should have a tag with topic name.

Relevant log output

No response

Screenshot

No response

Additional context

No response

Jaeger backend version

No response

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

No response

Deployment configs

No response

abliqo commented 1 year ago

I will make a change.