Guaranteed throughput samplers should report the actual lower bound in the tags

jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform

https://www.jaegertracing.io/

Apache License 2.0

20.61k stars 2.45k forks source link

Guaranteed throughput samplers should report the actual lower bound in the tags #5

Open yurishkuro opened 8 years ago

yurishkuro commented 8 years ago

Currently several implementations are reporting tags sampling.type=lowerbound, sampling.param=$rate when lower bound sampler is triggered, where $rate is the sampling rate of the probabilistic sampler. We should change it to report the actual lower bound value, for consistency.

[ ] Node client
[ ] Go client
[ ] Python client
[ ] Java client

yurishkuro commented 7 years ago

@black-adder are you doing this?

jpkrohling commented 5 years ago

Is this still relevant?

yurishkuro commented 5 years ago

it is, but low priority