jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform
https://www.jaegertracing.io/
Apache License 2.0
19.85k stars 2.37k forks source link

[Feature]: Jaeger SPM - Filter metrics on page by tag #5438

Open serban-nicusor-toptal opened 2 months ago

serban-nicusor-toptal commented 2 months ago

Requirement

Hello!

Is there a feature planned for the SPM page to allow filtering by tags?

We would love to see data per environment but as of now, there's no option to do it in the UI, thus forcing us to have two separate instances to see the different data.

Thanks!

Problem

Having to do duplicate instances for filtering data in the UI.

Proposal

Implement a filtering method based on tags for the SPM ui.

Open questions

Is this planned?

yurishkuro commented 2 months ago

sounds useful. Please provide more details. How are you doing it now with two instances?

serban-nicusor-toptal commented 2 months ago

Hey, devs want in some cases to watch the SPM metrics of PROD. Thus one method of doing this is to just have 2 separate Jaegers. One that ingests lower-envs data and one for prod only.

Edit: If we could have something similar to Tags in the Search pannel, that would be great. When used, that should filter the data just for that tag in the SPM page. Thus not having the need to have 2x Jaegers. image Now you can only filter by service name and span kind image

This is great for single-environment Jaegers, but if you want to have a single instance to handle multiple environments, all that data in SPM will just be merged together and won't be that useful anymore. Keep in mind, one reason to have a single jaeger is because your traces will be continuous across services thus it's easier to follow. SPM filtering by tags will complement this Jaeger setup and make that data even more useful.

serban-nicusor-toptal commented 1 month ago

Hello! Any luck with this?

varshith257 commented 1 month ago

Hey @serban-nicusor-toptal, Jaeger v2 SPM Project has been added to the LFX Mentorship Term 2. That mentee could help you implement this after the project is done or any other contributor soon(maybe me).

Currently, most of the contributors are focusing on other issues related to the v2 roadmap and cleaning the codebase of deprecated components

yurishkuro commented 1 month ago

That mentee could help you implement this

this is not accurate. Mentees work on specific projects, we can't make any promises about additional tickets. This ticket is open for volunteers.

varshith257 commented 1 month ago

That mentee could help you implement this

this is not accurate. Mentees work on specific projects, we can't make any promises about additional tickets. This ticket is open for volunteers.

I agree with it. So I mentioned a mentee or any other contributor. As that mentee could be very well versed with SPM once the LFX Project is done maybe that mentee could complete it faster if other contributors have not yet solved this ticket by that time. So, I mentioned it :)

varshith257 commented 1 month ago

@serban-nicusor-toptal Couldn't you give a try?

serban-nicusor-toptal commented 3 weeks ago

Hey, I'm a bit busy with a migration but I'll take a look over a weekend.