search

jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform
https://www.jaegertracing.io/
Apache License 2.0
20.25k stars 2.42k forks source link

Enable more revive linter rules #5506

Open yurishkuro opened 3 months ago

yurishkuro commented 3 months ago

In #5505 we introduced a revive linter, but had to disable many of its rules because they were breaking on some places in the code. https://github.com/jaegertracing/jaeger/blob/b38d2f9bc18806b6e716f6f666a786f0aca7d912/.golangci.yml#L154

We can re-enable those rules incrementally by fixing the corresponding breaks one rule at a time (make lint should succeed) and removing the disabling entry from the config.

FlamingSaint commented 3 months ago

Is it okay to remove multiple rules in the same PR ?

yurishkuro commented 3 months ago

Only if the changes are really small. I would recommend not mixing different changes / rules in one PR.