search

jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform
https://www.jaegertracing.io/
Apache License 2.0
20.51k stars 2.44k forks source link

[jaeger v2] Observability and Healthchecks #5633

Open yurishkuro opened 5 months ago

yurishkuro commented 5 months ago

Part of https://github.com/jaegertracing/jaeger/issues/5240

(1) Currently jaeger-v2 components are initialized without observability clients. We need to instantiate appropriate logging, tracing, and metrics clients and pass them to the components. The existing code uses internal metrics API, which needs to be bridged to OTEL metrics to minimize code changes.

(2) Jaeger-v1 components can report their readiness using an internal health check API that is connected to the healthcheck endpoint on the admin port. We need to implement similar capability in Jaeger-v2.

Expected Outcome: Achieve parity in observability of jaeger-v2 compared to jaeger-v1

yurishkuro commented 4 months ago

@Wise-Wizard fyi https://github.com/open-telemetry/opentelemetry-collector/pull/10443/files. I don't know if it's immediately useful for us.

Wise-Wizard commented 4 months ago

@Wise-Wizard fyi https://github.com/open-telemetry/opentelemetry-collector/pull/10443/files. I don't know if it's immediately useful for us.

Yes, went through this. Metrics can now be configured using a yaml file. Are you suggesting that I should now put my focus on creating the unified telemetry container?

yurishkuro commented 4 months ago

No. Using that metagen would require using OTEL API for metrics directly, which is not possible without lots of rewriting. Let's go with the original plan. We might come back to this in the future.

mahadzaryab1 commented 2 weeks ago

@yurishkuro what's the status of this ticket? anything I can help with here?

yurishkuro commented 2 weeks ago

I think it's still open, we need to revisit what was and wasn't done for each component.