jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform
https://www.jaegertracing.io/
Apache License 2.0
20.45k stars 2.44k forks source link

[v2] Add support for optional fields for config struct #5828

Open yurishkuro opened 2 months ago

yurishkuro commented 2 months ago

Looking for a volunteer to add support for optional fields for config structs.

Objective: create a draft PR with a prototype solution outlined in https://github.com/go-viper/mapstructure/issues/37 (make sure it's a draft to avoid creating notifications noise to go-viper maintainers). Update this ticket with a link so that we can collaborate on that prototype.

nag0yan commented 2 months ago

@yurishkuro Hello. Can I try this issue?

yurishkuro commented 2 months ago

You don't need to ask

mahadzaryab1 commented 2 months ago

@yurishkuro opened a draft at https://github.com/go-viper/mapstructure/pull/42. Let me know if you have any feedback and I'd be happy to incorporate it in.

akstron commented 1 week ago

Hi @mahadzaryab1 I think this issue can be closed since your PR got merged?

yurishkuro commented 1 week ago

issue is not solved