Add OTLP JSON support for Kafka e2e Integration tests

joeyyy09 commented 2 months ago

Which problem is this PR solving?

This PR addresses the issue of verifying Kafka e2e integration tests for otlp_json formats.

Description of the changes

Verified if the Kafka e2e integration tests run for otlp_json formats.
Used a fork of mine (github.com/joeyyy09/opentelemetry-collector-contrib) to incorporate necessary changes and verify the process.

How was this change tested?

Ran the Kafka e2e integration tests locally using the modified configuration.

Checklist

[x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
[x] I have signed all commits
[] I have added unit tests for the new functionality
[x] I have run lint and test steps successfully
- for jaeger: make lint test
- for jaeger-ui: yarn lint and yarn test

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.48%. Comparing base (9eaa882) to head (eea655a). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #5935 +/- ## ========================================== - Coverage 96.49% 96.48% -0.02% ========================================== Files 352 352 Lines 19973 19973 ========================================== - Hits 19273 19270 -3 - Misses 518 520 +2 - Partials 182 183 +1 ``` | [Flag](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | Coverage Δ | | |---|---|---| | [badger_v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `8.42% <ø> (ø)` | | | [badger_v2](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `1.70% <ø> (ø)` | | | [cassandra-4.x-v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `14.57% <ø> (ø)` | | | [cassandra-4.x-v2](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `1.64% <ø> (ø)` | | | [cassandra-5.x-v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `14.57% <ø> (ø)` | | | [cassandra-5.x-v2](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `1.64% <ø> (ø)` | | | [elasticsearch-6.x-v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `18.72% <ø> (-0.02%)` | :arrow_down: | | [elasticsearch-7.x-v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `18.80% <ø> (ø)` | | | [elasticsearch-8.x-v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `18.97% <ø> (ø)` | | | [elasticsearch-8.x-v2](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `1.69% <ø> (ø)` | | | [grpc_v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `8.78% <ø> (+0.01%)` | :arrow_up: | | [grpc_v2](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `6.72% <ø> (+0.01%)` | :arrow_up: | | [kafka-v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `8.99% <ø> (ø)` | | | [kafka-v2](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `1.70% <ø> (ø)` | | | [memory_v2](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `1.69% <ø> (-0.02%)` | :arrow_down: | | [opensearch-1.x-v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `18.86% <ø> (ø)` | | | [opensearch-2.x-v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `18.85% <ø> (ø)` | | | [opensearch-2.x-v2](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `1.70% <ø> (+0.01%)` | :arrow_up: | | [tailsampling-processor](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `0.48% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/jaegertracing/jaeger/pull/5935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `95.39% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yurishkuro commented 2 months ago

please link to OTEL PR

joeyyy09 commented 2 months ago

will be good to go after the next release of otel-collector-contrib

yurishkuro commented 3 weeks ago

otel-collector-contrib was upgraded, trying this fix again

joeyyy09 commented 3 weeks ago

otel-collector-contrib was upgraded, trying this fix again

That's great! I think now this is ready to go! Thanks! 🚀

yurishkuro commented 3 weeks ago

🎉

jaegertracing / jaeger