search

jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform
https://www.jaegertracing.io/
Apache License 2.0
20.52k stars 2.44k forks source link

Help upgrading the linter #5974

Closed yurishkuro closed 2 months ago

yurishkuro commented 2 months ago

PR #5966 tries to upgrade the linter, but runs into many new lint issues that need to be fixed before upgrade can be merged. Most of them are about signed/unsigned conversions, which we generally force-ignore.

Success criteria: gh pr checkout 5966 and make lint

anishbista60 commented 2 months ago

@yurishkuro works fine in my machine. why it is asking for credentials ?

git push origin dependabot/go_modules/internal/tools/github.com/golangci/golangci-lint-1.61.0 

remote: Permission to jaegertracing/jaeger.git denied to anishbista60.
yurishkuro commented 2 months ago

Create a new branch and push as a new PR.

anishbista60 commented 2 months ago

@yurishkuro before i was trying to push without creating fork :) . I don't know what i was thinking at that time.

dosubot[bot] commented 1 month ago

To address the signed/unsigned conversion lint issues in PR #5966 and successfully upgrade the linter, you can modify the .golangci.yml configuration file to exclude these specific lint issues. Here is an example of how you can do this:

issues:
  exclude-rules:
    - linters: [govet]
      text: "signed/unsigned mismatch"  # Add this line to exclude signed/unsigned conversion issues
  exclude-dirs-use-default: false
  exclude-dirs:
    - mocks
    - thrift-0.9.2
    - .*-gen
  exclude-files:
    - ".*.pb.go$"
  max-issues-per-linter: 0
  max-same-issues: 0

# ... rest of the configuration

This configuration will exclude the signed/unsigned mismatch issues reported by the govet linter, allowing you to proceed with the linter upgrade without these specific issues blocking the process [1].

To continue talking to Dosu, mention @dosu.