search

jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform
https://www.jaegertracing.io/
Apache License 2.0
20.52k stars 2.44k forks source link

[query] Switch to use OTEL's http/grpc servers #6026

Closed yurishkuro closed 2 weeks ago

yurishkuro commented 1 month ago

In #6023 we changed http/grpc servers in the query service to be configured via OTEL config structs, but we still have a custom implementation for creating the servers. We should fully switch to OTEL's implementations. This will be another breaking change because in OTEL the servers cannot share the same port, which is today supported in the query service via cmux.

Garvit-77 commented 1 month ago

Hello @yurishkuro I would like to give it a try

yurishkuro commented 1 month ago

@Garvit-77 go ahead

mahadzaryab1 commented 1 month ago

@yurishkuro what should be passed in for component.Host in the ToSever method?

yurishkuro commented 1 month ago

When running in v2 mode we have the real host available in the extension. For v1 it's ok to pass noop, but we need to make sure that we would still get the metrics from these endpoints as we get today.

Garvit-77 commented 1 month ago

`type Server struct { querySvc querysvc.QueryService queryOptions QueryOptions

conn          net.Listener
grpcConn      net.Listener
httpConn      net.Listener
grpcServer    *grpc.Server
httpServer    *httpServer
separatePorts bool
bgFinished    sync.WaitGroup
telemetery.Setting

}` As we're trying to completely switch to OTEL can't we change or remove the Server Struct ?