jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform
https://www.jaegertracing.io/
Apache License 2.0
20.52k stars 2.44k forks source link

[jaeger-v2] Consolidate v1 and v2 Configurations for GRPC Storage #6042

Closed mahadzaryab1 closed 1 month ago

mahadzaryab1 commented 1 month ago

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.90%. Comparing base (d6631f5) to head (79311ef). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6042 +/- ## ========================================== - Coverage 96.92% 96.90% -0.02% ========================================== Files 349 349 Lines 16600 16587 -13 ========================================== - Hits 16089 16074 -15 - Misses 328 329 +1 - Partials 183 184 +1 ``` | [Flag](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | Coverage Δ | | |---|---|---| | [badger_v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `8.00% <0.00%> (+0.01%)` | :arrow_up: | | [badger_v2](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `1.82% <0.00%> (+<0.01%)` | :arrow_up: | | [cassandra-4.x-v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `15.77% <0.00%> (+0.02%)` | :arrow_up: | | [cassandra-4.x-v2](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `1.74% <0.00%> (+<0.01%)` | :arrow_up: | | [cassandra-5.x-v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `15.77% <0.00%> (+0.02%)` | :arrow_up: | | [cassandra-5.x-v2](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `1.74% <0.00%> (+<0.01%)` | :arrow_up: | | [elasticsearch-6.x-v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `18.71% <0.00%> (+0.01%)` | :arrow_up: | | [elasticsearch-7.x-v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `18.77% <0.00%> (+0.02%)` | :arrow_up: | | [elasticsearch-8.x-v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `18.96% <0.00%> (+0.01%)` | :arrow_up: | | [elasticsearch-8.x-v2](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `1.81% <0.00%> (-0.01%)` | :arrow_down: | | [grpc_v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `9.38% <73.33%> (-0.15%)` | :arrow_down: | | [grpc_v2](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `7.13% <0.00%> (+0.01%)` | :arrow_up: | | [kafka-v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `9.71% <0.00%> (+0.01%)` | :arrow_up: | | [kafka-v2](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `1.82% <0.00%> (+<0.01%)` | :arrow_up: | | [memory_v2](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `1.82% <0.00%> (+<0.01%)` | :arrow_up: | | [opensearch-1.x-v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `18.81% <0.00%> (+0.01%)` | :arrow_up: | | [opensearch-2.x-v1](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `18.81% <0.00%> (+0.02%)` | :arrow_up: | | [opensearch-2.x-v2](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `1.81% <0.00%> (-0.01%)` | :arrow_down: | | [tailsampling-processor](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `0.46% <0.00%> (+<0.01%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/jaegertracing/jaeger/pull/6042/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing) | `95.70% <100.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jaegertracing#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yurishkuro commented 1 month ago

lgtm

mahadzaryab1 commented 1 month ago

@yurishkuro I don't believe this is a breaking change because the v1 config was being translated to v2 which is what was being used. Let me know if that's incorrect.