jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform
https://www.jaegertracing.io/
Apache License 2.0
20.6k stars 2.45k forks source link

Collector-sampling #6096

Closed Garvit-77 closed 1 month ago

Garvit-77 commented 1 month ago

We appreciate your contribution to the Jaeger project! 👋🎉 -->

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Garvit-77 commented 1 month ago

please let me know any changes @yurishkuro @mahadzaryab1

inosmeet commented 1 month ago

Hey @Garvit-77! All the commits must be signed in order to pass the DCO check of the GitHub.

yurishkuro commented 1 month ago

Signed commits is not the concern for me here - the PR itself is meaningless, it just deletes two files. I wouldn't open an issue if the problem was with deleting two files.

Garvit-77 commented 1 month ago

I Absolutely get that and to solve the issue Even i wasn't Deleting two files, rather just changed the endpoints for the function GetSamplingRate to sample the collector . I will check what went wrong and raise another pr Thank You.