search

jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform
https://www.jaegertracing.io/
Apache License 2.0
20.6k stars 2.45k forks source link

rebuild-ui is broken #6097

Closed yurishkuro closed 1 month ago

yurishkuro commented 1 month ago 
$ make rebuild-ui
::group::rebuild-ui logs
bash ./scripts/rebuild-ui.sh
+ cd jaeger-ui
+ git fetch --all --unshallow --tags
fatal: --unshallow on a complete repository does not make sense
make: *** [rebuild-ui] Error 128

cc @andreasgerstmayr

andreasgerstmayr commented 1 month ago

I added --unshallow because without it the script didn't work when pointing jaeger-ui to a non-tagged commit. Didn't realize git complains if the repo is already unshallowed :|

yurishkuro commented 1 month ago

the script didn't work when pointing jaeger-ui to a non-tagged commit

Seems to work fine for me when I removed --unshallow. Perhaps your local repo had an issue with how the submodule was initialized.

andreasgerstmayr commented 1 month ago

It works locally, but not in CI. GitHub actions checks repos out as shallow by default. We do have git fetch --prune --unshallow --tags in the workflow file to unshallow the repo, but afaics that only unshallows the root repository and not all submodules.