search

jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform
https://www.jaegertracing.io/
Apache License 2.0
20.6k stars 2.45k forks source link

[query] Drop Support For Same Host Ports #6117

Open mahadzaryab1 opened 1 month ago

mahadzaryab1 commented 1 month ago

Requirement

This issue can be tackled after Feb 2025.

In https://github.com/jaegertracing/jaeger/issues/6026, the query server was migrated to use OTEL's implementation of HTTP and GRPC servers. Our implementation supported having the GRPC and HTTP server being hosted on the same port via cmux, however, OTEL's implementation does not support this. For backwards compatibility purposes, https://github.com/jaegertracing/jaeger/issues/6026 did not drop support for the same ports but rather just logged a warning to allow users to migrate away from this functionality. Once we have waited for three months or two minor version bumps (whichever is later), we can drop support for hosting grpc and query server on the same port.

abuzaforfagun commented 1 month ago

I am interested in working on this issue.

yurishkuro commented 1 month ago

This is aimed for Feb 2025, not earlier, per our deprecation policy.