jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform
https://www.jaegertracing.io/
Apache License 2.0
20.42k stars 2.44k forks source link

[Feature]: Add optional time window when fetching trace by id using grpc-plugin #6123

Closed rim99 closed 1 week ago

rim99 commented 1 week ago

Requirement

We are using Jaeger UI to explore traces managed by Grafana Tempo.

Jaeger query uses GRPC plugin to send requrest to Tempo cluster.

Problem

Although currently this thing works, Jaeger cannot send optional time window to hint Tempo to query limited blocks from S3

Proposal

I would suggest to add optional time window (start & end timestamp) in GRPC storage plugin proto file: https://github.com/jaegertracing/jaeger/blob/85d558dff128feb767f7d5b9c70e3683745ecc9c/plugin/storage/grpc/proto/storage.proto#L69

Different backends can decide how to use it.

Open questions

No response

yurishkuro commented 1 week ago

Duplicate of #4150