Add optional time window in TraceGetParameters

jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform

https://www.jaegertracing.io/

Apache License 2.0

20.54k stars 2.44k forks source link

Add optional time window in TraceGetParameters #6159

Open rim99 opened 2 weeks ago

rim99 commented 2 weeks ago

Which problem is this PR solving?

Resolves #4150

Description of the changes

add optional time window when fetching trace by id

How was this change tested?

unittest

Checklist

[x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
[x] I have signed all commits
[x] I have added unit tests for the new functionality
[x] I have run lint and test steps successfully
- for jaeger: make lint test
- for jaeger-ui: yarn lint and yarn test

yurishkuro commented 1 day ago

please rebase

rim99 commented 1 day ago

@yurishkuro Updated bsaed on comments, please reivew this PR, thanks

yurishkuro commented 1 day ago

@rim99 this PR is too large, please break it into logical pieces. At minimum grpc storage changes could be a separate PR, e.g. changing the IDL. The anonymizer change can be separate.

yurishkuro commented 1 day ago

you have jaeger-ui submodule change, it's not related