jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform
https://www.jaegertracing.io/
Apache License 2.0
20.44k stars 2.44k forks source link

Numeric tags lose precision when using ElasticSearch #685

Closed kevinearls closed 5 years ago

kevinearls commented 6 years ago

I created a tag using ".withTag("floatTag", Math.PI)". When using Cassandra or the all-in-one it returns "3.141592653589793" (which is what (Number) Math.PI returns) but with ElasticSearch I only get "3.141592654"

pavolloffay commented 5 years ago

I have tried to reproduce with Jaeger 1.12 and ES 5.6.10 and I got 3.141592653589793.

The span was reported using java client.

      tracer.buildSpan("foo")
          .withTag("string", "00001")
          .withTag("integer", 1)
          .withTag("float", 1.001)
          .withTag("string1", "1")
          .withTag("float1", new Double(1))
          .withTag("PI", PI)
 {
        "_index" : "foo-jaeger-span-2019-06-21",
        "_type" : "span",
        "_id" : "AWt5InjDRGeesqzp7Hyq",
        "_score" : 1.0,
        "_source" : {
          "traceID" : "9a63497350dfb606",
          "spanID" : "9a63497350dfb606",
          "flags" : 1,
          "operationName" : "foo",
          "references" : [ ],
          "startTime" : 1561105429470000,
          "startTimeMillis" : 1561105429470,
          "duration" : 18,
          "tags" : [ ],
          "tag" : {
            "PI" : 3.141592653589793,
            "float" : 1.001,
            "float1" : 1,
            "integer" : 1,
            "internal@span@format" : "jaeger",
            "sampler@param" : true,
            "sampler@type" : "const",
            "string" : "00001",
            "string1" : "1"
          },
          "logs" : [ ],
          "process" : {
            "serviceName" : "eight-shards",
            "tags" : [ ],
            "tag" : {
              "hostname" : "dhcp-144-223.gva.redhat.com",
              "ip" : "10.33.144.223",
              "jaeger@version" : "Java-0.35.0"
            }
          }
        }
      },

Screenshot of Jaeger UI

I am closing this is it is not an issue anymore, feel free to re-open is similar issues happen.