Closed yurishkuro closed 6 years ago
@pavolloffay is there anything else we need before the release?
LGTM, although you had one comment: https://github.com/jaegertracing/legacy-client-java/issues/8#issuecomment-380483077
the build failed with Could not get unknown property 'ossrhUsername' for NexusStagingExtension(serverUrl:https://oss.sonatype.org/service/local/, username:null, password:null,
Merging #12 into master will increase coverage by
0.16%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #12 +/- ##
============================================
+ Coverage 84.73% 84.89% +0.16%
Complexity 607 607
============================================
Files 94 94
Lines 2410 2410
Branches 271 271
============================================
+ Hits 2042 2046 +4
+ Misses 276 272 -4
Partials 92 92
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...e/src/main/java/com/uber/jaeger/Configuration.java | 89.96% <ø> (ø) |
37 <0> (ø) |
:arrow_down: |
...er/jaeger/tracerresolver/JaegerTracerResolver.java | 100% <ø> (ø) |
2 <0> (ø) |
:arrow_down: |
...ger-core/src/main/java/com/uber/jaeger/Tracer.java | 87.14% <ø> (ø) |
23 <0> (ø) |
:arrow_down: |
...java/com/uber/jaeger/reporters/RemoteReporter.java | 87.05% <0%> (+2.35%) |
8% <0%> (ø) |
:arrow_down: |
...ain/java/com/uber/jaeger/senders/ThriftSender.java | 79.54% <0%> (+4.54%) |
10% <0%> (ø) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ef9f4c3...cd7b3a2. Read the comment docs.
Signed-off-by: Yuri Shkuro ys@uber.com
Resolves #8