Able to enter any grade for the subject

[jaejayrome]

Description: As a User, I could enter any alphabet as the grade for the subject, theoretically, there isn't a "Z" grade that can be assigned to subjects but I am able to do so.

Steps to Reproduce:

1. Add any user and append "sub/science-Z"

Evidence:

Suggestions: Use enums for grades to prevent such mishaps

[nus-se-bot]

Team's Response

It is not very feasible to implement constraints on what letter grades can be used for subject as the user might have students from different education backgrounds and differing grading systems. Younger students for example, especially those in kindergarten may not use the commonly used grading system of A, B, C... etc., but instead use animals, veggies, place names, values, etc. for their grades. E.g. a kindergarten may give their students a Zebra sticker on their homework for doing a good job, a Dolphin sticker for doing a great job, etc. instead of using letter grades. In this case, if the student has a Zebra, then it would make sense for the tutor to save their grade as Z.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement:

I apologise that using 'Z' might not be clear enough for you but I think that your counter argument misses the point that a user is able to enter any grade that they want, which is the title of the bug report. This includes adding "!!" as a grade which surely can't be used at any education level. Even if it is not feasible to add in any constraints throughout, there should be some minimal level of checking being enforced, else perhaps the non-functional requirements should be scoped better in the UG to cover this or the target audience could be more concised to include (e.g. A Level Students whereby the grades range from U-A).

Therefore, I think this is a valid bug report.

---