search

jaejayrome / pe

0 stars 0 forks source link

Name is advertised as not unique but edit command does otherwise #9

Open jaejayrome opened 6 months ago

jaejayrome commented 6 months ago

Description: In the UG, it is advertised that the names can be unique between students but when I tried to edit a student's name to have the same name as another, it fails.

Steps to Reproduce:

  1. Create 2 Students
  2. Edit 1 Student to have the same name as the other person

Screenshot 2024-04-19 at 4.48.27 PM.png

Screenshot 2024-04-19 at 4.47.47 PM.png

Suggestion: Remove the checking of constraints for names on edit command

soc-se-bot commented 6 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

TutorPro allows duplicate persons with same name and email

Outline The UG states that TutorPro does not allow duplicate persons. They can have the same name but phone and email must be unique.

Evidence in UG Screenshot 2024-04-19 at 4.47.27 PM.png

What actually happens? It seems that TutorPro actually does not allow people of same names, but allows people of same phone and email. Please see the evidence below.

Why Medium Severity If users don't figure this out themselves, they might not be able to enter any users as TutorPro will block the command actions. The UG and app behaviour are different.

Same name different phone and email: Screenshot See index 9 and my command input.

Screenshot 2024-04-19 at 4.50.52 PM.png

Different name but same phone and email: Screenshot See index 11 and 12.

Screenshot 2024-04-19 at 4.49.57 PM.png

[original: nus-cs2103-AY2324S2/pe-interim#5216] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is actually a documentation bug as it is intended for students to be able to have the same phone number and email. This is because especially for younger students, their point-of-contact might be their parents, and if they have the same point-of-contact, they will have the same phone number and email.

Hence this part is a low severity documentation bug.

For the name part, it is a functionality bug. However, this will not cause a huge inconvenience to the user as they can just add numbering if they happen to have students/parents with the same names, e.g. if there are 3 Jane Does (which is already highly unlikely), they can just save their contact names as Jane Doe 1, Jane Doe 2, and Jane Doe 3.

Hence, this bug with the names is not as important as the work already done in v1.4. Hence, it is a low severity documentation bug.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The duplicated bug ticket mentions about the deviation from the UG behaviour when a user is trying to perform the "add" command. In this case, we are talking about the "edit" command which deviates from the intended behaviour, meaning that the EditCommand class did not make the relevant fixes accordingly which means that both "Add" and "Edit" would have to change in different sections of the codebase in order to attain the intended behaviour.

## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** I disagree because as per what is mentioned above, there have to be changes to the EditCommandParser in order to ensure that the proper constraints are being aligned with the UG and this would call for a code change rather than a documentation change.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]