search

jaelpark / chamferwm

A tiling X11 window manager with Vulkan compositor.
https://jaelpark.github.io/chamferwm-docs/
BSD 3-Clause "New" or "Revised" License
249 stars 11 forks source link

Unbreak build with Clang #13

Closed jbeich closed 4 years ago

jaelpark commented 4 years ago

@jbeich Thanks for the fixes! I merged the other PR. In this one there's one problem with 8be2bbd however, the reinterpreted_cast does not actually make the RunCompositor a CompositorInterface. As a result, GetFontSize() cannot be called, and the title bars do not show up. As an alternative, I propose we retain the dynamic_cast, and instead move the RunCompositor class definition above RunBackend to fix the error.

jbeich commented 4 years ago

retain the dynamic_cast, and instead move the RunCompositor

Done. Still builds fine.

jaelpark commented 4 years ago

Looks all good now, thanks a lot. 👍