jaemk / cached

Rust cache structures and easy function memoization
MIT License
1.57k stars 95 forks source link

Feature/disk cache sync on change and sled connection config #194

Closed BaxHugh closed 7 months ago

BaxHugh commented 7 months ago

This PR concerns only the DiskCache

Closes https://github.com/jaemk/cached/issues/190

The main features of this PR are

This replaces https://github.com/jaemk/cached/pull/192

(the PRs in my clone are all stacked, but I don't think I can do that within this repo, so it is in one big PR to master here)

BaxHugh commented 7 months ago

This will have a few small merge conflicts with the changes in https://github.com/jaemk/cached/pull/185. So happy to merge this after that PR is merged.

But if someone could have a little review @omid @jaemk, that would be fantastic as this is something I'm hoping to use very soon in my work project. (I've linked to separate smaller PRs to make diffs easier to digest).

Also, if there's any PRs in particularly that it'd be helpful for me to help with reviewing, let me know..

jaemk commented 7 months ago

@BaxHugh would you mind resolving the disk.rs conflicts for me

BaxHugh commented 7 months ago

@jaemk, no problem. Done: (rebased onto master)