Separate store types - Githubissues

jaemk / cached

Rust cache structures and easy function memoization

MIT License

1.58k stars 95 forks source link

Separate store types #69

Closed omid closed 3 years ago

omid commented 3 years ago

Here I separated the store types to make it clearer and easier to spot issues.

I had to:

Repeat the test methods, which is not bad :)
Make some cache store properties, pub(super), but for consistency, I made all of them pub(super)!
Create some type aliases in the super module to be backward compatible.

Now, instead of having a ~2K file, we have 5 files between 250-650 lines.

PS: This PR is so opinionated, feel free to reject it :)

jaemk commented 3 years ago

Nice, this was sorely needed. Unfortunately there was a separate PR that had gone through a couple conflict resolution cycles so I merged that one first. Would you mind resolving those conflicts to the SizedCache store? Probably easiest to just copy/paste the whole thing again into the new file

omid commented 3 years ago

@jaemk sure, no problem.

jaemk commented 3 years ago

Looks good @omid , just two comments/questions

omid commented 3 years ago

@jaemk How can I push it forward? :)

jaemk commented 3 years ago

Sorry, fell off my radar - Looks good! Thanks @omid !