jaemk / migrant_lib

Embeddable migration management
23 stars 8 forks source link

Allow downstream crates to decide on how rusqlite should be built #8

Closed mehcode closed 6 years ago

mehcode commented 6 years ago

As cargo features are additive, using migrant_lib in a crate currently forces the crate to use bundled rusqlite.

jaemk commented 6 years ago

Good idea -- Would you mind adding a note under the "Available Features" table in src/lib.rs to let users know that if they want the "sqlite-driver" (in this case, rusqlite) to be bundled with the executable, they need to add rusqlite as a separate dependency with the bundled feature - even if they aren't using rusqlite directly themselves? (and then use readme.sh to regen the README) << I guess this only matters for crates like migrant which don't actually use rusqlite, but still want sqlite bundled, so I guess the note isn't really necessary.