search

jaemk / self_update

Self updates for rust executables
MIT License
796 stars 69 forks source link

feat/rust-tls: Feature flag to use rust tls instead of native dep #43

Closed joshuef closed 4 years ago

joshuef commented 4 years ago

Enable opt-in use of pure tls implementation, to avoid reqwest using native openssl implementations (which can be problematic on linux)

joshuef commented 4 years ago

@jaemk I'm not sure I know enough about the tests to debug the one failing here: https://travis-ci.org/jaemk/self_update/jobs/649526005?utm_medium=notification&utm_source=github_status

Any pointers you could give on this? (Or why it may be only this test that's failing?)

jaemk commented 4 years ago

@joshuef I wonder if the latest version of ring dropped support for 32bit osx?

joshuef commented 4 years ago

Hmm, sadly no change log over there, or any docs on upgrades, so I don’t know.

But, i can see some PRs hanging around for a while now for 32bit iOS. So I’d wager that’s not going to get fixed anytime soon :(

Is 32bit apple support a dealbreaker? Apple themselves have been killing off 32bit since iOS 11 and Catalina doesn’t support 32 bit anymore at all...

jaemk commented 4 years ago

I don't think it's a deal breaker. Let's comment out the 32bit osx build in the travis.yml config and add a comment to the rustls feature flag description saying that this one is not supported on 32bit osx

joshuef commented 4 years ago

That's passing nicely now 🎉 . Let me know if any more changes are needed. 👍

jaemk commented 4 years ago

Nice, thanks!

ctaggart commented 4 years ago

@joshuef, I think you solved my 3-month-old stackoverflow question. Thanks! https://stackoverflow.com/questions/59994525/how-do-i-specify-features-for-a-sub-dependency-in-cargo