jaemk / self_update

Self updates for rust executables
MIT License
796 stars 69 forks source link

Clean up dangling temporary directories on Windows #70

Closed t-mw closed 3 years ago

t-mw commented 3 years ago

Easiest solution I can think of to avoid temporary directories building up as discussed in https://github.com/jaemk/self_update/pull/69. This creates a separate temporary directory just for the exe backup, which is manually removed on Windows the next time the updated exe is run. Could go in a patch release (last PR from me hopefully).

Backing up the exe to a separate temporary directory allows us to:

t-mw commented 3 years ago

Getting a docker rate limit error on one of the CI jobs, need to try again later.

t-mw commented 3 years ago

Tests passed now

jaemk commented 3 years ago

Nice, thanks @t-mw !