search

jaerrib / waterleaf-icon-theme

Waterleaf icon theme for Linux
Creative Commons Attribution Share Alike 4.0 International
7 stars 0 forks source link

Some new icons don't follow Composition guidelines #14

Open q4osteam opened 4 years ago

q4osteam commented 4 years ago

Some icons added or updated since the latest stable release https://github.com/jaerrib/waterleaf-icon-theme/releases/tag/20191025 don't follow guidelines, in most cases sizing and a few shadowing as well.

Icons in question:

jaerrib commented 4 years ago

I'll take a look at these. However, I've noticed that both Paper and Papirus (which are upstream of Waterleaf) use shadows in size 32 icons yet we had decided not to for Paper-Q4OS/Waterleaf. I would suggest adapting to the rest of the theme as a less difficult task compared with needing to modify nearly every other size 32 icon that existed before. Any thoughts?

q4osteam commented 4 years ago

We would prefer not to use shadows for new and updated 32 sized icons. We needn't to modify large amount of existing icons, so it could be left as is at the moment. However, if you would consider adapting the Paper/Papirus theme approach more convenient, we will agree to do so.

jaerrib commented 4 years ago

From the standpoint of consistency with the original Paper theme and any imported Papirus icons, I think it would be better to include shadows and highlights on the size 32 icons. That being the case, I will close this bug report and create a new one to cover modifying the designer guidelines and updating the necessary size 32 icons.

q4osteam commented 4 years ago

We have reopened this one, because the main part of the report - icons sizing issue has not been resolved completely. Feel free to close it again, if you consider it better, we can particularize the sizing issue in a new report. Thank you for working on that.

jaerrib commented 4 years ago

For the list of icons in the original post, are you saying that all size variants need to be addressed or just some of them?

q4osteam commented 4 years ago

At lease one size variant of all icons mentioned in the OP need to be adjusted to conform guidelines. Some size variants may be correct, however some are obviously incorrect as visible from a quick visual comparison.

q4osteam commented 4 years ago

In addition, we have noticed, some of 22/24 icons have shadows and effects, which is not consistent with the guidelines.

jaerrib commented 1 year ago

Have any of the troublesome icons been replaced with ones from Papirus?

q4osteam commented 10 months ago

It needs to be checked as soon as the new version of Waterleaf is released.