search

jaerrib / waterleaf-icon-theme

Waterleaf icon theme for Linux
Creative Commons Attribution Share Alike 4.0 International
7 stars 0 forks source link

Network manager icons misshapen in TDE #5

Closed q4osteam closed 4 years ago

q4osteam commented 4 years ago

Network manager icons misshapen in TDE, at least for 32 size, see the picture: issue1

jaerrib commented 4 years ago

I can confirm the bug. What's odd is that I don't see it in Inkscape or when viewing the preview in Dolphin. Either way, I'll take a look. I'm thinking it may be something to do with fractional pixel positioning. I may end up tweaking the design somewhat to be more in line with Advanced Network Configuration icon, which has the "globe" positioned vertically instead of on a slant and doesn't seem to exhibit the same issue,

jaerrib commented 4 years ago

After reworking the icon to use the spacing as described in the developer's guide (and slightly tweaking the middle portion of the icon), I was able to correct the issue.

Before: network_before

After: network_after

I'll work on both the normal and disabled variations of the icon in all the sizes and upload those in te next day or so.

q4osteam commented 4 years ago

Yes, that looks perfect.

jaerrib commented 4 years ago

I pushed the changes for all sizes on both icons to the development branch (2920e98). They are also revised to use the new standards listed in the developer's guide. If everything is good, I'll mark the issue as closed.

q4osteam commented 4 years ago

Looks fine now for sizes >= 32, however another distortion arose in 16 and 24, see screenshots before and after the (2920e98) update.

Before: issue6a After: issue6b

q4osteam commented 4 years ago

We have tested the latest development snapshot post (b8d6808) and the issue looks to be fixed. Great job, thanks.