jaewonjoo / webp

Automatically exported from code.google.com/p/webp
0 stars 0 forks source link

mingw64 build failure - 'interface' is already defined in the win32 runtime #210

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
patch:

diff --git a/src/utils/thread.c b/src/utils/thread.c
index 6b1c9da..ae60b20 100644
--- a/src/utils/thread.c
+++ b/src/utils/thread.c
@@ -290,14 +290,14 @@ static WebPWorkerInterface g_worker_interface = {
   Init, Reset, Sync, Launch, Execute, End
 };

-int WebPSetWorkerInterface(const WebPWorkerInterface* const interface) {
-  if (interface == NULL ||
-      interface->Init == NULL || interface->Reset == NULL ||
-      interface->Sync == NULL || interface->Launch == NULL ||
-      interface->Execute == NULL || interface->End == NULL) {
+int WebPSetWorkerInterface(const WebPWorkerInterface* const interface_) {
+  if (interface_ == NULL ||
+      interface_->Init == NULL || interface_->Reset == NULL ||
+      interface_->Sync == NULL || interface_->Launch == NULL ||
+      interface_->Execute == NULL || interface_->End == NULL) {
     return 0;
   }
-  g_worker_interface = *interface;
+  g_worker_interface = *interface_;
   return 1;
 }

Original issue reported on code.google.com by grizzly.nyo on 23 Jun 2014 at 7:06

GoogleCodeExporter commented 8 years ago
https://gerrit.chromium.org/gerrit/70608 should take care of this.

Thanks for the report!

Original comment by pascal.m...@gmail.com on 23 Jun 2014 at 9:22

GoogleCodeExporter commented 8 years ago
I know there's interface in C#, but this sounds like a toolchain specific 
thing. Out of curiosity what does you build setup and configure look like? None 
of our mingw-w64 or visual studio builds reported any issue.

Original comment by jz...@google.com on 24 Jun 2014 at 7:56

GoogleCodeExporter commented 8 years ago
I'm using 64bit msys2 environment started up in with mingw64 profile. It
was the latest builds available from the repository. Does the above answers
your question?
 On Jun 24, 2014 10:56 PM, <webp@googlecode.com> wrote:

Original comment by grizzly.nyo on 24 Jun 2014 at 8:45

GoogleCodeExporter commented 8 years ago
Yes, thank you for that and the original report. I've avoided setting up an 
msys2 environment, but this seems to happen in my msys1.0 setup too. I'll see 
about adding that to our regular builds.

Original comment by jz...@google.com on 24 Jun 2014 at 11:43

GoogleCodeExporter commented 8 years ago
We have a nightly running msys1.0 now, marking this fixed as the original issue 
has been addressed. If there are any great differences in msys2 I'll look at 
setting one up.

Original comment by jz...@google.com on 23 Jul 2014 at 12:17