jaewonjoo / webp

Automatically exported from code.google.com/p/webp
0 stars 0 forks source link

build error with NEON on aarch64 #230

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Build libwebp 0.4.2 with gcc 4.8 for linux / aarch64

What is the expected output? What do you see instead?

[  128s] In file included from upsampling_neon.c:20:0:
[  128s] upsampling_neon.c: In function 'UpsampleRgbLinePair':
[  128s] upsampling_neon.c:140:10: error: incompatible types when initializing 
type 'int32x4_t' using type 'int32x2_t'
[  128s]      yl = vmlaq_lane_s32(yl, bl, cf32, 0);                             
  \
[  128s]           ^
[  128s] upsampling_neon.c:166:3: note: in expansion of macro 'CONVERT8'
[  128s]    CONVERT8(FMT, XSTEP, len, top_y, uv, top_dst, cur_x)                
  \
[  128s]    ^
[  128s] upsampling_neon.c:219:5: note: in expansion of macro 'CONVERT2RGB_8'
[  128s]      CONVERT2RGB_8(FMT, XSTEP, top_y, bottom_y, r_uv,                  
  \
[  128s]      ^
[  128s] upsampling_neon.c:234:1: note: in expansion of macro 
'NEON_UPSAMPLE_FUNC'
[  128s]  NEON_UPSAMPLE_FUNC(UpsampleRgbLinePair,  Rgb,  3)

What version of the product are you using? On what operating system?

Please provide any additional information below.

Original issue reported on code.google.com by dmu...@gmail.com on 28 Oct 2014 at 9:40

GoogleCodeExporter commented 8 years ago
Yes this is/was a bug with 4.8. I filed something on the android side and I 
believe it was posted upstream, but they've since moved to 4.9.
I had an adapter around to deal with this, but never pushed it since debian and 
android both moved to gcc-4.9. Is that a possibility in your case?

Original comment by jz...@google.com on 28 Oct 2014 at 2:23

GoogleCodeExporter commented 8 years ago
Fix for android is here [1], I don't have an upstream gcc bug handy.

[1] https://android-review.googlesource.com/#/c/99470

Original comment by jz...@google.com on 28 Oct 2014 at 2:25

GoogleCodeExporter commented 8 years ago
I can backport the fix to our gcc 4.8. Thanks for the pointer!

Original comment by dmu...@gmail.com on 28 Oct 2014 at 5:21