Closed jafeha closed 11 years ago
shouldn't this be fixed with 51fa89f ? i can't test it right now, but i'm pretty sure this issue should be solved.
uups. i broke this. fucking regression, we need tests.
this will fix it.
subprocess.check_call(["mount", "-t", "hfsplus", "-o",
"loop", os.path.join(tempdir, parser.get('thunderbird_mac',
'uncompressedfile')), os.path.join(tempdir,"/dmg/")])
note that i broke the line up in 3 pieces to conform with pep8
i got an mainLogger error as not being defined in extract_files.py when starting to extract files. can u confirm this with the most recent push i commited (i've split the functions into utils and extract_files)? i'll fix this subprocess call later today.
thats the problem with the extract_files.py. the logger isnt defined in there. it should work because of from utils import *, gut lets discuss this via jabber or even more interactive
i made some stuff in https://github.com/jojoo-/parabird/commit/d664d2942ecb3288ba6dad7a15ba55990dde1479 but cant sent a pull request as you didn't merge the first one
we need to find a way to encapsulate the logging stuff as a function, but i don't know how. maybe a setup_logger function that is only called once in the parabirdy_build?
then, if we need to debug, we would have to call it beforehand, but that does'nt seem like a problem
Merged. U can send another pull req.
fixed for a while now.
i've got an error extracting the freshly from the dmg created img file:
this problem comes from these calls here:
i'll comment 'em out for pushing the newest version now. i do not understand why this error occurs, i must have messed with the syntax.