install-p4dev-v5.sh "The unauthenticated git protocol on port 9418 is no longer supported"

First of all thanks for your ongoing effort and the nice v5 of your install-p4dev script! The speedup thanks to the package-based installation is really great and most appreciated! install-p4dev-v5.sh used to work flawlessly up until some days ago, but now it seams like GitHub does not allow unauthenticated clones anymore and mininet cannot be installed using git clone git://github.com/mininet/mininet anymore...

Successfully installed grpcio-1.44.0 psutil-5.9.0 ptf-0.9.3 scapy-2.4.5 six-1.16.0
+ echo ------------------------------------------------------------
------------------------------------------------------------
+ echo 'Installing Mininet - not necessary to run P4 programs, but useful if'
Installing Mininet - not necessary to run P4 programs, but useful if
+ echo 'you want to run tutorials from https://github.com/p4lang/tutorials'
you want to run tutorials from https://github.com/p4lang/tutorials
+ echo repository.
repository.
+ echo 'start install mininet:'
start install mininet:
+ set -x
+ date
Fri Mar 18 15:00:33 UTC 2022
+ git clone git://github.com/mininet/mininet mininet
Cloning into 'mininet'...
fatal: remote error:
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
p4@prona-image-test-v5-again:~$

seams to be easy to fix, as I only needed to change line 241 from git: to https://

p4@prona-image-test-v5-again:~/p4-guide$ diff bin/install-p4dev-v5.sh.patched bin/install-p4dev-v5.sh.old
241c241
< git clone https://github.com/mininet/mininet mininet
---
> git clone git://github.com/mininet/mininet mininet
p4@prona-image-test-v5-again:~/p4-guide$

afterwards. install-p4dev-v5.sh went through without errors again.

Thanks!

Sebastian

jafingerhut / p4-guide

install-p4dev-v5.sh "The unauthenticated git protocol on port 9418 is no longer supported" #46