jafioti / luminal

Deep learning at the speed of light.
https://luminalai.com
Apache License 2.0
1.48k stars 89 forks source link

Fix CUDA build on Rust 1.77 #45

Closed zeux closed 7 months ago

zeux commented 7 months ago
use luminal::{
    nn::{embedding::Embedding, norm::RMSNorm},

After these fixes, cargo run --release --features cuda works from examples/mistral on Rust 1.77.

jafioti commented 7 months ago

@zeux Looks good! Only nitpick I have is changing all the nn modules to pub. Can you instead just change this:

use luminal::{
    nn::{embedding::Embedding, norm::RMSNorm},

to

use luminal::prelude::*;

because all the nn modules are re-exported by nn, which should be covered by prelude.

zeux commented 7 months ago

Yeah definitely, I can fix the import side - wasn't sure which direction to go.

jafioti commented 7 months ago

Looks great, thanks!