Closed zeux closed 7 months ago
@zeux Looks good! Only nitpick I have is changing all the nn modules to pub. Can you instead just change this:
use luminal::{
nn::{embedding::Embedding, norm::RMSNorm},
to
use luminal::prelude::*;
because all the nn modules are re-exported by nn, which should be covered by prelude.
Yeah definitely, I can fix the import side - wasn't sure which direction to go.
Looks great, thanks!
After these fixes,
cargo run --release --features cuda
works from examples/mistral on Rust 1.77.