search

jagaapple / next-secure-headers

Sets secure response headers for Next.js.
MIT License
317 stars 13 forks source link

Add navigation directives #41

Closed naotone closed 3 years ago

naotone commented 3 years ago

Add "form-action" and "frame-ancestors" as Navigation directives. Move "navigate-to" to Navigation directives from Reporting directives.

Reference: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy#navigation_directives

Thanks for developing this repo! This pull request is included jest test codes, so It should be fine. Btw, I hope I could read your blog posts this year! I enjoy it as an Apple信者.

codecov[bot] commented 3 years ago

Codecov Report

Merging #41 (0d3c600) into master (87f6129) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          208       217    +9     
  Branches        85        91    +6     
=========================================
+ Hits           208       217    +9
Impacted Files Coverage Δ
src/rules/content-security-policy.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87f6129...0d3c600. Read the comment docs.

jagaapple commented 3 years ago

@naotone Thank you for your pull request 😃, but I'm sorry, currently I don't have time to commit to this library. I'll check and merge this pull request and release a new version in February 🙇🏻

Btw, I hope I could read your blog posts this year!

😂😂😂

helfi92 commented 3 years ago

@jagaapple Any chance we could merge this PR? Thanks!

naotone commented 3 years ago

@jagaapple I missed your reply, sorry. Please let me know if you need help!