jagaapple / next-secure-headers

Sets secure response headers for Next.js.
MIT License
317 stars 13 forks source link

Add about frame-ancestors CSP directive to readme #46

Closed mattdell closed 3 years ago

mattdell commented 3 years ago

New Features

Changes and Fixes

codecov[bot] commented 3 years ago

Codecov Report

Merging #46 (54e150f) into master (87f6129) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          208       208           
  Branches        85        85           
=========================================
  Hits           208       208           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87f6129...54e150f. Read the comment docs.

mattdell commented 3 years ago

Must say I don't see how the code coverage is going down so much as I've added tests...! 😅

jagaapple commented 3 years ago

Thank you for your pull request😃 I'm busy, so I'll review this within two weeks.

This feature will be merged in v2.2.0.

mattdell commented 3 years ago

That's great, @jagaapple

I figured out the issue with code coverage. I had left a .only in the unit tests...! 🤦🏻‍♂️

I will also add some documentation to the README when I get a chance.

helfi92 commented 3 years ago

Looking forward to this! 🎉

jagaapple commented 3 years ago

This PR is duplicated with #41 , but I will merge the README @mattdell edited about X-Frame-Options header.

Thank you!