search

jagenjo / rendeer.js

Light-weight 3D Scene graph library with renderer in WebGL
MIT License
88 stars 16 forks source link

GLTF scene nodes index fix. #3

Closed repalash closed 4 years ago

repalash commented 4 years ago

Fix to load files where the first node is not the scene root. And a minor change in gltf example so that IDE(Jetbrains) does not show an error with embedded glsl code.

Tested with: https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/CesiumMilkTruck Without this commit, only wheels(of the truck) are loaded.

jagenjo commented 4 years ago

Hi

I cannot accept your commit, as the multistring character is not supported by old JS versions and I like to keep my code that way.

About the multi root node GLTF Im working on that with a cleaner solution.

Thanks anyway for the PR.

repalash commented 4 years ago

The issue is not about multi-root node GLTF, but with GLTF files where the index of root node != 0.

jagenjo commented 4 years ago

you were right, I fixed the GLTF. sorry for not using your PR but there were other changes in my code.