search

jagenjo / webglstudio.js

A full open source 3D graphics editor in the browser, with scene editor, coding pad, graph editor, virtual file system, and many features more.
MIT License
5.21k stars 605 forks source link

./editor/fileserver should not be gitignored by default #36

Closed Yugloocamai closed 5 years ago

Yugloocamai commented 6 years ago

For obvious reasons. This should be left up to the end user. Do not .gitignore files that don't exist in this repository, but could possibly be added at a later point.

jagenjo commented 6 years ago

It doesnt exist in this repository but it exist in all the installations of WebGLStudio (it is the recommended folder to install litefileserver).

If I do not add it to the gitignore then when I commit I could commit my whole fileserver system to the repository (several gigabytes).

So I think is much safer to add it to the gitignore

Yugloocamai commented 6 years ago

Why would that whole folder be added when you commit, unless you explicitly added it? Git doesn't add files to a commit unless you tell it to.

jagenjo commented 6 years ago

git add *

yep, Im lazy as that, but also it could happend. Anyway, that folder should NEVER be in the repository