search

jagheterfredrik / wallbox-pwn

Gain root access to Wallbox chargers such as Pulsar Plus, Copper SB
14 stars 7 forks source link

Update wallbox-pwn.py with longer BLE scanner time and print devices found to screen #13

Open nzkiwi68 opened 6 months ago

nzkiwi68 commented 6 months ago

Set a longer scan time (default time is too short) and print devices found to screen so user can see you are in fact detecting devices.

jagheterfredrik commented 6 months ago

We already print the devices right after?

fixes #12

jagheterfredrik commented 6 months ago

Clarification: I'm happy to merge an increased timeout but please remove the print

nzkiwi68 commented 5 months ago

We already print the devices right after?

fixes #12

Sorry for my late reply.

Yes, you do print the devices, but only for the Wallbox devices that you find start start named "WB". If the Wallbox for some reason doesn't respond, then you print no devices at all.

By printing all devices found, the user can be reassured that the bluetooth scanner is working and finding BLE devices, otherwise there is no feedback to know if the scan worked at all.

jagheterfredrik commented 5 months ago

Perhaps “Found X devices but none of them is a Wallbox” / “No Bluetooth devices found, is Bluetooth enabled?”

nzkiwi68 commented 5 months ago

I like your thinking. Your way is less confusing for the user so they cannot try and select a BLE that isn't a Wallbox and get very confused...

nzkiwi68 commented 5 months ago

I'm no coder, perhaps you might be able to change the code to work your way?