jagi / meteor-astronomy-examples

http://astronomy.meteor.com
MIT License
18 stars 5 forks source link

valueAsDate not supported in Firefox? #16

Closed james1293 closed 7 years ago

james1293 commented 7 years ago

It seems that valueAsDate is not supported in Firefox (evidence here and here ). Therefore, in Firefox, the program will always think that the birth date is wrong.

Do you think this is a strong enough reason to switch to another way of converting the date input to a Date() object? I'm concerned that people will try this example in Firefox, and decide that Astronomy is broken when they try to submit the form and it does not work.

Let me know what you think, thanks!

lukejagodzinski commented 7 years ago

Yes I know about that limitation of FF. I don't know why I actually used valueAsDate here. It would work without that. That's why we have casting system in Astronomy. I will remove it and check if it's working. Thanks for reminding me about that!

lukejagodzinski commented 7 years ago

Ok I've made a few more fixes and now it should work properly