search

jagot / bsr

1 stars 3 forks source link

Cleanup #1

Open jagot opened 4 years ago

jagot commented 4 years ago

We need cleanup on various levels:

  1. [ ] Some codes use version 3 of the libraries, others version 4
  2. [x] Delete *.ff files (old versions of corresponding *.f90 files)
  3. [ ] Deduplication
    1. [ ] E.g. DBSR_HF is a self-standing code, reproducing a lot of the common libraries
    2. [ ] Could not DBSR_HF be merged into DBSR_MCHF? It would seem HF is just a special case of MCFH.
    3. [ ] Duplicated code in general can be found using https://pmd.github.io/

Anything else @katrham20 ?

katrham20 commented 4 years ago

Hi @jagot

I think that sounds like a good start for the first cleanup! For DBSR in particular HF will not be used very often so I think grouping them is a good idea.

I will try and work on the first point - I believe I have access to all the libraries locally and can add the needed ones here.