search

jagregory / cognito-local

Local emulator for Amazon Cognito
MIT License
278 stars 67 forks source link

Add given_name and family_name attributes to id token #361

Open alec-w opened 1 year ago

alec-w commented 1 year ago

Fixes #360

Adds the given_name and family_name attributes into the id token.

In our project making use of cognito-local (thanks for this) this addressed the problem for us.

Guidance would be helpful on whether this is indeed the correct fix and how the tests should be modified to prevent a future regression on these attributes (typescript not being my forte).

jagregory commented 1 year ago

I think this looks fine. Ideally, we'd have a canonical list of attributes which are supposed to be exposed via the tokens and then we could write tests which verify they're exposed (if they're set on the user), but unless someone volunteers to do that I'm happy to just merge.