Tweaks from the last few years

[CDAGaming]

I run a minecraft mod called CraftPresence that, until recently, was using a jar-in-jar'd fork of this implementation of Discord's IPC system.

There will probably be quite a few questions, of which I'd be glad to answer, though I still plan to keep maintaining this fork so long as mod my mod keeps growing. Thank you again for making this amazing tool, as it's been fun to keep it going for awhile +1

Here is a list of changes that have come over time, in a greatly summarized form:

• Added autoRegister support (WinRegistry class added for Windows, tested up to Java 17/18)
• Updated JUnixSocket to 2.4.0, technically superseeding #20
  • Technically, this can go higher, but steps have been taken to retain support for Java 7, so we cannot go higher at least in this scope.
  • Use GSON instead of org.json
  • Same reason as prior note, game environments can more easily implement GSON (Or already have it included)
  • Added individualized logging for a debug or verbose mode that could be helpful in debugging and filtering out logs for user-level
  • Now uses discord.com instead of discordapp.com where applicable (New endpoint)
  • Added support for partyPrivacy and the buttons array
  • Added support for MacOS, as well as locating the ipc pipe from the Snap and Flatpak Distributions of Discord
  • Note that Flatpak'd JVMs are unable to locate the IPC Pipe, unless also using a Flatpak distribution of Discord, due to sandboxing restrictions.

[jagrosh]

There's a lot to unpack here. While there are plenty of changes in this that I'd love to see get merged in, there's also a lot that I don't think should be added. This isn't a comprehensive list or review, but just a start for some of the things I think should be removed before this could be merged:

• Git/env/ci-related files, which seem tied more to your environment or build process than this project.
• Gradle, I find for the scope of this project maven is simpler to use.
• Main.java, which shouldn't be present in a library. JUnit tests would be fine if you need an executable test file.
• [ ... more things as I notice them ... ]

[CDAGaming]

I'm definitly happy to take feedback for this, though for what you've given so far:

• For the Main.java, I can easily remove that since the README already takes care of example usage
• The Gradle and CI/Env stuff I can easily split off as well (As I have a separate publish branch where that can go into)

Either way, definitely let me know of any more feedback. It definitely is a lot to sift through 😄 I'll start making changes hopefully later today/tomorrow to go along with your review, mostly since I know there's likely to be more feedback.

Edit: Notes 1, 2, and 3 have been applied to the branch! :smile:

[CDAGaming]

@jagrosh Any way we can get the ball rolling again on this PR, considering the recent fixes being made and the breaking API change discord has planned with the Pomelo Updates.