jagrosh / GiveawayBot

🎉 Hold giveaways quickly and easily on your Discord server!
https://giveawaybot.party
Apache License 2.0
646 stars 302 forks source link

[Feature Request] Rely on `create`/`manage_events` for `/gcreate` command permission #247

Open alsoGAMER opened 1 year ago

alsoGAMER commented 1 year ago

As also discussed in the Discord server with one support person (Naman), i think shifting away from manage_guild for some commands (like /gcreate) would benefit large communities (like mine) in helping not granting such dangerous permission to people in charge to only run giveaways/events in said community.

I hope you'll find the time to implement this or provide input on why it's not ideal to do it.

jagrosh commented 1 year ago

That permission isn't required, it's just the default (if you don't make any overrides). If you want to allow a user or role to use a command, set that in the Integrations tab (make an override for each command you want to allow a user or role to use).

alsoGAMER commented 1 year ago

If you want to allow a user or role to use a command, set that in the Integrations tab (make an override for each command you want to allow a user or role to use).

This i already know, what i'm saying tho is a change to default one.

jagrosh commented 1 year ago

I guess I'm confused then, I feel like the default permission to use all the bot's commands should match the permission needed to be able to add the bot to the server in the first place. I'm also unsure how changing the default helps the aforementioned issue (granting a dangerous permission), since you can give someone access to run giveaways without giving them that permission.

alsoGAMER commented 1 year ago

Lets say a user only has a role with only manage events, and that user runs the events aspect of a community, wouldn't be easier for admins to just grant that role without having to set specific overrides?

It also could allow for more granular access to commands, like

jagrosh commented 1 year ago

If a server is looking for granular access, they are going to be making overrides. Everything you've described there is already possible via the Integrations tab.

As for baseline (default) functionality, I feel like it would be confusing for someone to be able to add the bot (clearly they are a manager of the community) but then be unable to use its commands (ie, if they have Manage Server but not Manage Events).