jagrosh / MusicBot

🎶 A Discord music bot that's easy to set up and run yourself!
https://jmusicbot.com
Apache License 2.0
5.39k stars 2.58k forks source link

[Feature Request] (Releases) Put the release version into the pom.xml #1665

Closed eomanis closed 3 months ago

eomanis commented 3 months ago

Is your feature request related to a problem? Please describe.

The version of the Maven artifact produced by the releases' pom.xml files has so far always been "Snapshot".

What is your ideal solution to the problem?

Since we do have proper releases it would be prudent to put the actual release version number into the pom.xml /project/version node.

That would save me from having to run the pom.xml through an XSLT that sets the version.

How would this feature be used?

Makes it simpler to build a properly versioned Maven artifact.

Additional Info

This feature request has low priority.

Checklist

jagrosh commented 3 months ago

This is intentional so that self-built versions do not get confused with the official releases produced by our github actions. We don't provide any support for versions other than the jars provided on the releases page.

eomanis commented 3 months ago

Seems like me putting the version in there downstream goes against your intentions. I guess i'll put "<version>-aur" or something the like when I update the AUR package next time.