jagrosh / MusicBot

🎶 A Discord music bot that's easy to set up and run yourself!
https://jmusicbot.com
Apache License 2.0
5.39k stars 2.58k forks source link

[Bug Report] search works at the second attempt sometimes #443

Closed eyehol3 closed 4 years ago

eyehol3 commented 4 years ago

Describe the bug

i type play [request] first time - No results found i repeat same request: - Playing [smth]

To Reproduce Steps to reproduce the behavior:

  1. Run with java -Dnogui=true -jar JMusicBot-0.2.9-Mac.jar
  2. Do a command play [request]

Expected behavior results are found at the first attempt

Screenshots image

pheeef commented 4 years ago

image

I have the same Issue. Only this time it doesn't find anything with $search but on the second attempt the bots finds it with $play

alfonsojon commented 4 years ago

Describe the bug Occasionally, the bot fails to search for a song almost as though no results came up.

To Reproduce Steps to reproduce the behavior:

  1. Search for the same song many times for the sake of testing
  2. Notice it occasionally fails

Expected behavior I would assume it should successfully search every time.

Screenshots image

Debug Info

System Properties:
  java.version = 1.8.0_252
  java.vm.name = OpenJDK 64-Bit Server VM
  java.vm.specification.version = 1.8
  java.runtime.name = OpenJDK Runtime Environment
  java.runtime.version = 1.8.0_252-8u252-b09-1~18.04-b09
  java.specification.version = 1.8
  os.arch = amd64
  os.name = Linux

JMusicBot Information:
  Version = Snapshot
  Owner = 150301926821462016
  Prefix = @mention
  AltPrefix = m!
  MaxSeconds = 900
  NPImages = false
  SongInStatus = true
  StayInChannel = false
  UseEval = false
  UpdateAlerts = false

Dependency Information:
  JDA Version = 3.8.3_464
  JDA-Utilities Version = 2.1.5
  Lavaplayer Version = 1.3.49

Runtime Information:
  Total Memory = 135
  Used Memory = 92

Discord Information:
  ID = 666773938860458009
  Guilds = 1
  Users = 6332

Additional context I am running a JAR compiled from source to resolve an issue with fetching most songs; however, I have made no alterations to the source code and this issue has impacted the past two versions (or more) of the music bot.

Sanduhr32 commented 4 years ago

Self compiled copies aren't supported.

However why did you expect it to resolve the issue if no changes to the build file, libraries nor source code was made?

Java should not be affected by compiling the code on different operating systems nor cpu vendors / architectures.

JMusicbot uses Lavaplayer which comes with pre-built binaries for different operating systems and cpu architectures. If you believe the binary has an issue or isn't compatible then you might have to use a self compiled version of Lavaplayer resulting in a again unsupported self compiled JMusicbot.

alfonsojon commented 4 years ago

The jar I have is just 0.2.8 with an updated pom.xml to use lavaplayer 1.3.49. I have since updated to 0.2.9 as I saw that was out. @eyehol3 has reported the same issue on version 0.2.9 so it seems to still be an issue.

Sanduhr32 commented 4 years ago

If you compare 0.2.8 to 0.2.9 (this is a github link) then you see that there isn't a big change in JMusicbot, and that it might have a different source.

alfonsojon commented 4 years ago

image screenshot taken on 0.2.9

nexusdiscord commented 4 years ago

Untitled

I have same issue

hondasila commented 4 years ago

image same

iRealKsA commented 4 years ago

image ???????????? Please Fix it

spiderboyjk8 commented 4 years ago

Same issue please fix!!!

onlyyouX2 commented 4 years ago

Mr. jagrosh

The same problem , I think you should add YouTube search it would be better Thank you .

Sanduhr32 commented 4 years ago

YouTube changed the format of how it sends the data. This issue should be fixed in the next version of JMusicbot.

Djinnistorm commented 4 years ago

yea it's fixed in 1.3.50 version of lavaplayer, so rebuilding with that yourself or waiting are your two options.

onlyyouX2 commented 4 years ago

Waiting for update Version 0.3.0 , I used another bot until the new version come out

nexusdiscord commented 4 years ago

yea it's fixed in 1.3.50 version of lavaplayer, so rebuilding with that yourself or waiting are your two options.

still getting problem

hondasila commented 4 years ago

yea it's fixed in 1.3.50 version of lavaplayer, so rebuilding with that yourself or waiting are your two options.

still getting problem

do you rebuild it by yourself ?

nexusdiscord commented 4 years ago

yea it's fixed in 1.3.50 version of lavaplayer, so rebuilding with that yourself or waiting are your two options.

still getting problem

do you rebuild it by yourself ?

yes

hondasila commented 4 years ago

yes

i only cant convert .java (lavaplayerfile) to a .class to change it

jagrosh commented 4 years ago

Building the project yourself is not supported; please be patient for the next release, which will come out once lavaplayer's fix for this issue is stable.

jagrosh commented 4 years ago

This should be resolved as of version 0.2.10