jagrosh / Vortex

🌀 Discord Moderation Bot
https://github.com/jagrosh/Vortex/wiki
Apache License 2.0
571 stars 322 forks source link

Strikes don't automatically timeout members #154

Open Frostbyte0x70 opened 1 year ago

Frostbyte0x70 commented 1 year ago

When Vortex is configured to use timeouts instead of a muted role, triggering an automated mute punishment by giving a strike to a user does not apply any punishment, just logs the strike.

Seems like the part of the code responsible for this wasn't updated to support timeouts: https://github.com/jagrosh/Vortex/blob/e64f73b166cdb17da73c887bd1d70360207c7923/src/main/java/com/jagrosh/vortex/automod/StrikeHandler.java#L148

This section should be changed to timeout the user if no muted role is set, as well as checking for the MODERATE_MEMBERS permission instead of MANAGE_ROLES when that's the case.

ALocked1 commented 1 year ago

Vortex hasn't been made to timeout users yet, it only recognizes if a user got timed out and logs it as a tempmute. You still have to use the Muted role until then.

Frostbyte0x70 commented 1 year ago

It doesn't? The >>muterole command says it does use timeouts when no role is set: https://github.com/jagrosh/Vortex/blob/e64f73b166cdb17da73c887bd1d70360207c7923/src/main/java/com/jagrosh/vortex/commands/settings/MuteroleCmd.java#L52

ALocked1 commented 1 year ago

I think jag added the text in advanced but to my knowledge Vortex is incapable of using timeouts until JDA Utils is updated