jags111 / efficiency-nodes-comfyui

A collection of ComfyUI custom nodes.- Awesome smart way to work with nodes!
https://civitai.com/models/32342
GNU General Public License v3.0
932 stars 96 forks source link

SDXL bug #138

Open BornSaint opened 6 months ago

BornSaint commented 6 months ago

i can't understand what's happening, i have a lot of stuff installed, but none of the conflict nodes are installed. Error only with SDXL, no matter what workflow i'm using

`Error occurred when executing Eff. Loader SDXL:

'SDXLClipModel' object has no attribute 'set_clip_options'

File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/execution.py", line 152, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/execution.py", line 82, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/execution.py", line 75, in map_node_over_list results.append(getattr(obj, func)(**slice_dict(input_data_all, i))) File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/custom_nodes/efficiency-nodes-comfyui/efficiency_nodes.py", line 236, in efficientloaderSDXL return super().efficientloader(base_ckpt_name, vae_name, clip_skip, lora_name, lora_model_strength, lora_clip_strength, File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/custom_nodes/efficiency-nodes-comfyui/efficiency_nodes.py", line 172, in efficientloader encode_prompts(positive, negative, token_normalization, weight_interpretation, clip, clip_skip, File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/custom_nodes/efficiency-nodes-comfyui/efficiency_nodes.py", line 73, in encode_prompts positive_encoded = bnk_adv_encode.AdvancedCLIPTextEncode().encode(clip, positive_prompt, token_normalization, weight_interpretation)[0] File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/custom_nodes/efficiency-nodes-comfyui/py/bnk_adv_encode.py", line 312, in encode embeddings_final, pooled = advanced_encode(clip, text, token_normalization, weight_interpretation, w_max=1.0, File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/custom_nodes/efficiency-nodes-comfyui/py/bnk_adv_encode.py", line 246, in advanced_encode embsl, = advanced_encode_from_tokens(tokenized['l'], File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/custom_nodes/efficiency-nodes-comfyui/py/bnk_adv_encode.py", line 183, in advanced_encode_from_tokens weighted_emb, pooled_base = encode_func(weighted_tokens) File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/custom_nodes/efficiency-nodes-comfyui/py/bnk_adv_encode.py", line 249, in lambda x: encode_token_weights(clip, x, encode_token_weights_l), File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/custom_nodes/efficiency-nodes-comfyui/py/bnk_adv_encode.py", line 226, in encode_token_weights model.cond_stage_model.set_clip_options({"layer": model.layer_idx}) File "/home/r/.local/share/krita/ai_diffusion/server/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1688, in getattr raise AttributeError(f"'{type(self).name}' object has no attribute '{name}'")`

YoucanBaby commented 6 months ago

same error

YoucanBaby commented 6 months ago

i can't understand what's happening, i have a lot of stuff installed, but none of the conflict nodes are installed. Error only with SDXL, no matter what workflow i'm using

`Error occurred when executing Eff. Loader SDXL:

'SDXLClipModel' object has no attribute 'set_clip_options'

File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/execution.py", line 152, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/execution.py", line 82, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/execution.py", line 75, in map_node_over_list results.append(getattr(obj, func)(slice_dict(input_data_all, i))) File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/custom_nodes/efficiency-nodes-comfyui/efficiency_nodes.py", line 236, in efficientloaderSDXL return super().efficientloader(base_ckpt_name, vae_name, clip_skip, lora_name, lora_model_strength, lora_clip_strength, File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/custom_nodes/efficiency-nodes-comfyui/efficiency_nodes.py", line 172, in efficientloader encode_prompts(positive, negative, token_normalization, weight_interpretation, clip, clip_skip, File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/custom_nodes/efficiency-nodes-comfyui/efficiency_nodes.py", line 73, in encode_prompts positive_encoded = bnk_adv_encode.AdvancedCLIPTextEncode().encode(clip, positive_prompt, token_normalization, weight_interpretation)[0] File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/custom_nodes/efficiency-nodes-comfyui/py/bnk_adv_encode.py", line 312, in encode embeddings_final, pooled = advanced_encode(clip, text, token_normalization, weight_interpretation, w_max=1.0, File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/custom_nodes/efficiency-nodes-comfyui/py/bnk_adv_encode.py", line 246, in advanced_encode embsl, = advanced_encode_from_tokens(tokenized['l'], File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/custom_nodes/efficiency-nodes-comfyui/py/bnk_adv_encode.py", line 183, in advanced_encode_from_tokens weighted_emb, pooled_base = encode_func(weighted_tokens) File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/custom_nodes/efficiency-nodes-comfyui/py/bnk_adv_encode.py", line 249, in lambda x: encode_token_weights(clip, x, encode_token_weights_l), File "/mnt/SSD500/cache/ai_diffusion/server/ComfyUI/custom_nodes/efficiency-nodes-comfyui/py/bnk_adv_encode.py", line 226, in encode_token_weights model.cond_stage_model.set_clip_options({"layer": model.layer_idx}) File "/home/r/.local/share/krita/ai_diffusion/server/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1688, in getattr raise AttributeError(f"'{type(self).name**}' object has no attribute '{name}'")`

https://github.com/jags111/efficiency-nodes-comfyui/issues/113#issuecomment-1964069748

jags111 commented 5 months ago

i can t seem to get this error as tested now with all updates incl comfyUI done. Please update comfy and check. update Eff nodes and check.

2024-04-06_11-09-04
LoFiApostasy commented 5 months ago

Same error, all i have installed is "ComfyUI-Manager" and "efficiency-nodes-comfyui".