jags111 / efficiency-nodes-comfyui

A collection of ComfyUI custom nodes.- Awesome smart way to work with nodes!
https://civitai.com/models/32342
GNU General Public License v3.0
955 stars 96 forks source link

comfyui version b1fd26f error #200

Closed sanhedasheng closed 4 months ago

sanhedasheng commented 4 months ago

Starting with version number b1fd26f, efficiency-nodes-comfyui does not work and quits with an error halfway through.

I am using intel_xpu.


b1fd26f code

TODO: more reliable way of checking for flash attention?

    if is_nvidia(): #pytorch flash attention only works on Nvidia
        return True
    if is_intel_xpu():
        return True
return False
jags111 commented 4 months ago

can you try the FOOCUS version of effeciency sampler and check if it gives error

sanhedasheng commented 4 months ago

I don't know what is FOOCUS version, but I have the others test.

Today, I tested comfyui version b1fd26f, released 2024-06-05, and tested several earlier versions of efficiency-nodes-comfyui, all of which crashed and quit the program.

Then, tested the latest version of comfyui (bb1969c), the program no longer crashes, efficiency-nodes-comfyui behaves normally, but SDXL runs out of the black picture. 2 picture is newsest comfyui and efficiency-nodes-comfyui can't support SDXL

jags111 commented 4 months ago

sdxl base needs refiner.. so it is not converting the same.. you need steps for base and steps for refiner.. May be that is the issue. Try any other standard SDXL model it will work. yes there is some noise conversion issues and i am checking

jags111 commented 4 months ago

Hai i realized that SDXL loader with Tuple and SDXL sampler are done with the intention of using base + refiner workflows. SO if you don't add refiner it will throw black and empty image. I have

2024-06-18_13-01-00

added a use case with a standard SDXL model for both base and refiner here which should give a clear idea on same.

sanhedasheng commented 4 months ago

eee I added a refiner model, same as the base model. I still return a black picture . I guess it has something to do with the fact that I am using intel xpu.

sanhedasheng commented 4 months ago

ccc ddd bbb

Base model plus refiner model. Program crashes.

jags111 commented 4 months ago

not sure .. it is to do with the basic packages of Torch having some issues.. so recheck how to have all that sorted and run some basic tests with your torch installation from comfy UI main package and test same. Also change your refiner step to work at 15 or some such and not -1

sanhedasheng commented 4 months ago

All right. Thank you.

I'm using back to the early version of comfyui, because your plugin is a must have for me.

This kind of problem may be solved without realizing it, comfyui's ecology has always been full of variables.

sanhedasheng commented 4 months ago

Hello. The problem has been solved. I reinstalled comfyui, reinstalled your plugin. Now I am able to use your plugin with the latest version of comfyui, and SDXL is working fine.