jags111 / efficiency-nodes-comfyui

A collection of ComfyUI custom nodes.- Awesome smart way to work with nodes!
https://civitai.com/models/32342
GNU General Public License v3.0
789 stars 80 forks source link

[Request] EfficientSamplerCustom #202

Open dathide opened 1 month ago

dathide commented 1 month ago

Thank you for your work on these custom nodes. I have been using TCD sampler extensions a lot lately, and they require the use of SamplerCustom. I have also been trying to create XY plots to test different TCD settings, and I saw that your nodes can do this easily for the built-in samplers. I would appreciate a new node called something like EfficientSamplerCustom based on SamplerCustom that can use the XY plot script with sampler and sigmas. This is the TCD extension I am using: https://github.com/JettHu/ComfyUI-TCD

jags111 commented 1 month ago

sure will work on this and update

dathide commented 1 month ago

Thanks for the quick response. Actually, it might be better to make a node called EfficientSamplerCustom (Advanced) based on SamplerCustom (Advanced) because that node accepts a custom guider input too. This will make it more compatible with other extensions that add new guiders and the built-in PerpNegGuider.

patientx commented 1 month ago

We need this for "align your steps" as well, am I correct ?

dathide commented 1 month ago

Yes, AYS is a scheduler node that provides sigmas and can only be used with the SamplerCustom nodes.